search

N-Shar-ma / Emoji-Card-Game

Emoji guessing card matching game, made using vanilla JavaScript, lots of css animations and the native HTML drag and drop API
https://emoji-card-game.netlify.app
19 stars 26 forks source link

Toggle button for switching light and dark mode is added. #51

Closed Utsab5 closed 1 year ago

Utsab5 commented 1 year ago

@N-Shar-ma ,I have added the toggle button. (issue #38 ) Please have a look and please add the hactoberfest labels in this PR.

N-Shar-ma commented 1 year ago

I had a cursory look right now, and my feedback would be to use just one dark class on the body, and toggle just that. For reference, you might want to have a look at the CSS here Also, all (or at least most of) the extra classes added look unnecessary. Just 1 dark class should be needed.

In the example linked above I'd used variables, which would be great to have here, but that could maybe be a follow up PR. For now, just using that 1 dark class combined with all the relevant elements' selectors should work too. For example:

.dark #landing-page {
 dark colors here
}

The colors and the toggle look fine though!

Utsab5 commented 1 year ago

Okay understood. I will let you know after changing the code.

Utsab5 commented 1 year ago

Hi @N-Shar-ma , i have made the changes. Please have a look and try to merge it under hactoberfest. PS: Sorry for my late response due to exams.