search

N-Shar-ma / Emoji-Card-Game

Emoji guessing card matching game, made using vanilla JavaScript, lots of css animations and the native HTML drag and drop API
https://emoji-card-game.netlify.app
20 stars 26 forks source link

Add feature to show credits for each deck's creator #6

Closed N-Shar-ma closed 1 year ago

N-Shar-ma commented 1 year ago

Each deck in this game is someone's brain child and deserves to be easily linked with it's creator!

Would appreciate if someone could add a field for the GitHub username (and optionally the full real name) of the creator of the deck in each deck object in the decks.js file, and then display it alongside the deck name in the category dropdown menu, and also later while playing through a deck. Specifics of how and where to show the name are open to discussion (which is encouraged!).

Figuring out the creator for each deck should be easy going through the commit history / PRs.

McCune1224 commented 1 year ago

Id be happy to work on this, should be as easy as adding another property called author to the decks with.js file for each deck.

If its okay, a tweak to the 'Contributing' section too mentioning for future deck makers to include their name in the author field would help too.

McCune1224 commented 1 year ago

Also, as for where to display the author, 2 places came to mind:

  1. A new line underneath the card depicted box with the author name would be a good spot. Might be a tight fit however with the yellow box.

  2. At the bottom of the screen with the same design as the card depicted box.

N-Shar-ma commented 1 year ago

That sounds like a great plan, @McCune1224! Appreciate the suggested tweak to the Contributing section as well.

I'd definitely prefer the 2nd location (at the bottom of the screen) for the author display since there's more room there.

Looking forward to your PR!