search

N-Shar-ma / Emoji-Card-Game

Emoji guessing card matching game, made using vanilla JavaScript, lots of css animations and the native HTML drag and drop API
https://emoji-card-game.netlify.app
19 stars 26 forks source link

Added sound for correct/wrong answers #63

Closed Gauravdarkslayer closed 1 year ago

Gauravdarkslayer commented 1 year ago

This is a fix for #12 .

CC: @N-Shar-ma

N-Shar-ma commented 1 year ago

That sounds good @Gauravdarkslayer! Could you also add a button with a microphone icon at the top left of the screen to mute / unmute the sound?

Many players might want to interact with the game quietly so they should have that option easily available

Gauravdarkslayer commented 1 year ago

Yes sure! Will do that ! @N-Shar-ma

Gauravdarkslayer commented 1 year ago

@N-Shar-ma Here you go, done the required changes, you can check. BTW can you please add hacktoberfest label in this issue ?

N-Shar-ma commented 1 year ago

@Gauravdarkslayer Thanks for the contribution! The usage of local storage to persist a user's preference was a really nice touch :)

Since the repository itself is tagged hacktoberfest, no other labels, on the issue or PR, should be required to make this count

Gauravdarkslayer commented 1 year ago

Yeah @N-Shar-ma , thanks for the review. :)