fix(chekbox): added disabled + checked props

N00nDay / stwui

Opinionated yet customizable Svelte-TailwindCSS component library

stwui.vercel.app

MIT License

450 stars 21 forks source link

fix(chekbox): added disabled + checked props #100

Closed kddige closed 1 year ago

kddige commented 1 year ago

As per issue #99, i have added disabled and checked props to the Checkbox component.

Whats changed

Checkbox now exports "disabled" and "checked" props
Added styling for disabled state
Added docs showing "disabled" and "checked" states.

Im still unsure how to handle compound variations in this project, currently i just used the "class:" syntax thats come by default in Svelte, but i would like some feedback on that.

Im happy to hear your toughts. 👍

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
stwui	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 12, 2023 at 8:59PM (UTC)

N00nDay commented 1 year ago

I totally agree with this PR. The only issue is that I am in the middle of making a major breaking change which this PR will conflict. I will just bake this PR into the current work I am doing with theming. Thank you for the work and I hope you will continue to contribute in the future!