Closed Geoffrey-D closed 2 years ago
Hey this is cool idea, I think it could be more consistent if there is no "ext" in event name and everything goes in same event. The "external" nature could be handled by sending an object like:
{ external: boolean, dataTransfer, node }
Also in your PR, events seems to be fired twice (drop can emit "drop" and "dropext")
What do you think ?
Hey this is cool idea, I think it could be more consistent if there is no "ext" in event name and everything goes in same event. The "external" nature could be handled by sending an object like:
{ external: boolean, dataTransfer, node }
Also in your PR, events seems to be fired twice (drop can emit "drop" and "dropext")
What do you think ?
Excellent idea, I didn't know if I could alter the standard events.
I made the changes, I let you check if it fits your idea :)
Looks really good ! Can you update documentation ?
Done! I also always added the "evt, external & dataTransfer" data to be more consistent
Is everything OK with this PR? can it be merged?
Seems that tests are broken can you repair it ? ^^
Sorry about that, fixed
Hello,
This PR triggers the following events when items are dropped from an external source:
Would it be possible to create a new npm version once this PR is merged?
Thx!