N0BOY / FT8CN

Run FT8 on Android
MIT License
321 stars 27 forks source link

Support audio streaming over CAT of (tr)uSDX #67

Closed d3m3vilurr closed 11 months ago

d3m3vilurr commented 11 months ago

same as #61 just rebased with Dev branch

N0BOY commented 11 months ago

@d3m3vilurr minor fix of MainViewModel. Please test on your (tr)uSDX.

Thanks for the PR.

d3m3vilurr commented 11 months ago

@N0BOY Hi. I read your partial revert patch of the https://github.com/N0BOY/FT8CN/pull/67/commits/8f5975b107166f2

trusdx's audio stream over CAT is not made a audio channel. it only uses the CAT serial channel. it mean, we cannot receive/transmit the sound via mic/speaker lines. so I'll expect that the patch wouldn't work well if an app flow doesn't changes between 0.89 and 0.90.

so, this setDataFromLan is wrong name now. it could be changed to setDataFromLanOrDataCable samely that this is reason of why I add onTransmitOverCAT

but, I'll test/share the result tonight, :)

d3m3vilurr commented 11 months ago

it has multiple compile errors. but i think you want to revert/clean up my dirty patches :) so i removed that my patch things which raised an error at the compile time.

expect result:

testing result: all tests failed after the revert patch

N0BOY commented 11 months ago

Hi Sunguk, there was some miscommunication between me and YOZ, when pushing out ffed0a8.

Please try again with 069205d, and see if you can at least compile it.

d3m3vilurr commented 11 months ago

@N0BOY It seems to work well. and also I couldn't find any problem in the patch code.

TX/RX is good and I made one QSO.

TY & 73 DE DS1UFX

N0BOY commented 11 months ago

Sounds good! However, @BG7YOZ already started the v0.91 revision before this merge. We may need to do another round of code review when have the next stable release candidate.