search

N0MoreSecr3ts / wraith

Uncover forgotten secrets and bring them back to life, haunting security and operations teams.
MIT License
206 stars 42 forks source link

Fix for the new GitHub token match #104

Closed Shashank-In closed 3 years ago

Shashank-In commented 3 years ago

Github token now starts with ghp_

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit 8ffee87f and detected 0 issues on this pull request.

View more on Code Climate.

mattyjones commented 3 years ago

@Shashank-In Thanks for this, I was unaware of the change! One thing, not a concern at this point but please pull from develop when submitting changes. I try my best to keep the master branch as stable as possible and not accept PR's against it unless unit and integration tests are also provided.

In this case, the change is near trivial in terms of code modification and I have automated testing to cover this but for larger code changes this would be rejected, unless 100% code coverage was also provided until it can get pulled against develop as that is always current, the master is typically only for proven code.

Shashank-In commented 3 years ago

Hi @mattyjones Yes, the regex will work for both cases' old one, and the new one as the number of characters is still 40, just that a _ has been introduced. Sorry I didn't read the doc. Next time I will make any PR on the dev. I have already tested it locally. So this will work.

Shashank-In commented 3 years ago

Hi @mattyjones Can we merge this?

mattyjones commented 3 years ago

@Shashank-In I will merge this week. I have a bunch of stuff to update and will be cutting a new release, to include this, within the next few days.

9oelM commented 2 years ago

Could we have another release please?