N0ich / dialogkey-DF

GNU General Public License v3.0
11 stars 3 forks source link

Disable space bar in ghost form after death #29

Closed ghost closed 8 months ago

ghost commented 1 year ago

Hello,

A huge annoyance is addon interaction with resurrection button in ghost form. Example:

  1. Die
  2. In spirit form, try to fly up on your drake / jump up
  3. As you can see, the 'cancel' button is pressed each time!!! instead of jumping/flying up image

Please find a way to solve this or disable this key when in ghost form as there is no reason for it imo

Thank you

FuriousProgrammer commented 1 year ago

So this isn't actually a bug, as such. DialogKey is correctly attempting to hit that button, but you don't want it to because you have Spacebar bound to jump/fly up.

I'd recommend changing the DialogKey keybind, personally, but another option is the custom blacklist. The in-game options for it aren't implemented yet (working on this Soon:tm:!) but the addon does currently work with it, you just need to add the dialogBlacklist Table to your WTF\Account\[AccountNumber]\SavedVariables\DialogKey.lua file, like this:

DialogKeyDFDB = {
    ["global"] = {
        ["dialogBlacklist"] = {
            "Resurrection in",
            "Another Example",
            "THE TURTLES MADE IT TO THE WATER",
        },
    },
}

Until I get the in-game options for this working, I'll keep the "Resurrection in" string in the built-in blacklist, at which point I'll move it to the custom blacklist as an example default option, as I agree this one should probably never be used!

ghost commented 1 year ago

Whatever change happened months ago actually fixed the issue. I cant see anyone actually wanting to press resurrect button in ghost form. It just invites accidents. Youre not saving any time. Personally resurrect should stay out of buttons that the addon controls. Sorry im not a dev if this doesnt make sense.

FuriousProgrammer commented 1 year ago

So that specific dialog (cancelling a BG resurrection timer) is one that sensible to be disabled, but there is no issue with the addon actually clicking, so I'm against completely disabling it in favor of making it a default option in the custom blacklist, as I said.

Personally, one of my main uses for this addon is accepting combat rezzes and releases, but I understand that some people explicitly don't want that, which is why there are options for it!

On Sun, Aug 6, 2023, 10:57 AM Rezy942 @.***> wrote:

Whatever change happened months ago actually fixed the issue. I cant see anyone actually wanting to press resurrect button in ghost form. It just invites accidents. Youre not saving any time. Personally resurrect should stay out of buttons that the addon controls. Sorry im not a dev if this doesnt make sense.

— Reply to this email directly, view it on GitHub https://github.com/N0ich/dialogkey-DF/issues/29#issuecomment-1666904127, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDZD6OHWNRW5RWSCBO65KDXT65FXANCNFSM6AAAAAAX5POI7U . You are receiving this because you modified the open/close state.Message ID: @.***>