search

N0ich / dialogkey-DF

GNU General Public License v3.0
11 stars 3 forks source link

Use OverrideBindings to allow using protected actions from popups #38

Closed Numynum closed 8 months ago

Numynum commented 10 months ago

Hi folks, This is a small proof of concept, that allows you to 'click' on protected popup buttons, without any errors I wouldn't say this is ready to just merge and release as-is, since some of the options (mainly just ignoreDisabledButtons) aren't supported I also didn't bother to clean up any of the old code and last but not least, I didn't spend too much time testing things, but it does allow me to e.g. upgrade my gear, use Tiered Medalion Setting on my neck, etc

this PR is mostly to give you a suggestion, and full example, to what might be a cleaner solution than your current one 🙂, feel free to do with it whatever you want ^^

(love the addon btw, appreciate the work you've put into supporting DF)

N0ich commented 10 months ago

Thank you I'm unfortunately not available to properly test this for now but I will as soon as I have the occasion to.

Numynum commented 10 months ago

I've played around with it a few days, and found and fixed a few issues (notably properly ignoring summons, and giving priority to popups when gossip windows or other supported windows are also open)

I'll keep playing with these changes, to see if I come across anything weird 🙂

N0ich commented 8 months ago

Merging as i've been testing and it looks like it works very well. Thank you so much :)