search

N0rthernL1ghts / unit-php

Alpine based Docker image for nginx-unit with PHP module
MIT License
4 stars 3 forks source link

Alpine image - PHP with --allow-embed #4

Open scheibling opened 1 year ago

scheibling commented 1 year ago

Stumbled on this as I was building my own version of the container, there is an easy way to compile the Alpine PHP Container to include the --allow-embed flag.

If you clone the repo at https://github.com/docker-library/php.git, the only thing that needs to be added is the --enable-embed flag in the following section

https://github.com/docker-library/php/blob/5bfc95d4880599cf9e85f5b5f99940cf123ebcf0/8.0/alpine3.16/cli/Dockerfile#L119-L163

xZero707 commented 1 year ago

Hi @scheibling . I will look into this. Thank you very much.

One of the reasons this was not investigated much is that I want to avoid maintaining own PHP base images. I will try to see if we can add this flag at this stage, but I doubt it.

Meanwhile, feel free to create PR if you have PoC.

scheibling commented 1 year ago

Don't have the time for a full PR at the moment, but I have a lot of code for this at github.com/cloudynes/docker-unit if you or anyone wants to have a look