N0taN3rd / wail

:whale2: One-Click User Instigated Preservation
http://matkelly.com/wail
GNU General Public License v3.0
121 stars 9 forks source link

Squished WAIL icon on loading screen #81

Open machawk1 opened 7 years ago

machawk1 commented 7 years ago

When loading, the WAIL icon has a pointier nose/head. Is the icon being dimensionally squeezed? screen shot 2017-05-16 at 3 22 18 pm

N0taN3rd commented 7 years ago

@machawk1 I use a circle effect to ensure the icon does not make the header portion too large

machawk1 commented 7 years ago

That explains the pointiness, @N0taN3rd . Is there any way to prevent the clipping? How would the icon being square cause the header portion to be any larger?

N0taN3rd commented 7 years ago

@machawk1 the icon is displayed via material-ui/Avatar and internally they apply

root: {
      color: color || avatar.color,
      backgroundColor: backgroundColor || avatar.backgroundColor,
      userSelect: 'none',
      display: 'inline-flex',
      alignItems: 'center',
      justifyContent: 'center',
      fontSize: size / 2,
      borderRadius: '50%',
      height: size,
      width: size
 },
icon: {
      color: color || avatar.color,
      width: size * 0.6,
      height: size * 0.6,
      fontSize: size * 0.6,
      margin: size * 0.2   
 }

Which maybe causing the clipping.

How would the icon being square cause the header portion to be any larger? Previous versions of Material-UI when the image displayed was largish and you did not supply styling the original width/height was used. So I used the circle effect to contain the icon as I was using the 256 sized icon to ensure that on high dpi screens (macs retina screens etc) the icon would look sharp.

machawk1 commented 7 years ago

@N0taN3rd Can you customize the Avatar lib to not use a border-radius? It's good that you accounted for high-res screens but on those screen it will be both crisp and clipped. ;)

N0taN3rd commented 7 years ago

@machawk1 I do believe I can easily since the material-ui library has matured from the time I created the component for the header and displaying the icon. But if not css tweaking will probably do the trick.

machawk1 commented 6 years ago

Still present in 1.2.0-beta. 😕