search

N0taN3rd / wail

:whale2: One-Click User Instigated Preservation
http://matkelly.com/wail
GNU General Public License v3.0
120 stars 9 forks source link

Missing image on acid test single-page capture #85

Closed machawk1 closed 7 years ago

machawk1 commented 7 years ago

Are you submitting a bug report or a feature request?

Bug.

What is the current behavior?

Missing image on acid test at http://acid.matkelly.com

What is the expected behavior?

All blue squares.

What's your environment?

WAIL 1.2.0-beta, macOS 10.12.5

Other information

screen shot 2017-07-19 at 11 03 24 pm

N0taN3rd commented 7 years ago

@machawk1 hehe believe I got bit by you gotta interact with the page! Where to put the scroll the page option??? Add additional option with scroll option (Page Only and Page Only and Scroll) or have a checkbox that only appears with these crawls

machawk1 commented 7 years ago

You may simply want to scroll by default, wait a few seconds, see if the DOM has changed and if so, repeat. This could also put you in an infinite loop w/ sites like Twitter.

N0taN3rd commented 7 years ago

@machawk1 that maybe the best option for now Might also solve some of the wail-ui issues concerning how fast preservation happens.

machawk1 commented 7 years ago

If you are going to use the above scheme, put a hard limit on the number of scroll iterations to ensure the actual preservation part is performed after the UI of the page has settled.

N0taN3rd commented 7 years ago

@machawk1 scrolling is bound by the initial document.documentElement.scrollHeight and a time duration of 4 seconds https://github.com/N0taN3rd/wail/blob/wail-electron/wail-archiver/pageEvals/helpers.js#L73 :smiley:

N0taN3rd commented 7 years ago

@machawk1 fixed and updated release binary screen shot 2017-07-20 at 2 20 27 am