search

N1ck / gifs-for-github

Repository for the GIFs for GitHub Chrome & Firefox Extension
https://chrome.google.com/webstore/detail/gifs-for-github/dkgjnpbipbdaoaadbdhpiokaemhlphep?hl=en
MIT License
194 stars 26 forks source link

GIF button appears below toolbar in certain breakpoints #73

Open mshunjan opened 9 months ago

mshunjan commented 9 months ago

Hi @N1ck . Thanks for the lovely tool. The problem was encountered on version 24.1.18 in both chrome (121.0.6167.185) and firefox (122.0.1).

Current Behavior

image

The GIF button renders below the toolbar at certain breakpoints. Specifically, when there is no more whitespace for the toolbar buttons, it gets rendered below.

Expected behavior

The GIF button gets moved to the menu (triple dot) items, or is placed within the toolbar.

Steps to reproduce

  1. Create a new issue on github.
  2. Resize browser horizontally until toolbar shrinks to displace GIF button.
dsayling commented 7 months ago

When enabled with "Refined Github" it appears to add multiple gif buttons that don't do anything along with the icon shortcuts for the table and collapsable content.

image
PatrykKuniczak commented 3 months ago

image

Each, on the smaller width, it's occur somewhere in textarea, it's annoying

I using Chrome latest on Win 11

Jonghakseo commented 3 months ago

@mshunjan @dsayling @PatrykKuniczak :)

I submitted a pull request (#79), If you want to use it locally before deployment, please unzip the file below and import it in developer mode

In details

  1. Open in browser - chrome://extensions
  2. Check - Developer mode
  3. Find and Click - Load unpacked extension
  4. Select - distribution folder you unzipped

distribution.zip

PatrykKuniczak commented 3 months ago

@Jonghakseo Gold boy ❤️