search

N3PDF / pdfflow

PDFflow is parton distribution function interpolation library written in Python and based on the TensorFlow framework.
https://pdfflow.readthedocs.io
Apache License 2.0
8 stars 0 forks source link

Wrong Uncertainties on performance benchmark #45

Closed marcorossi5 closed 3 years ago

marcorossi5 commented 4 years ago

Description

There could be an issue with the performance benchmark statistics. The problem relies in the following lines of code

Code example

https://github.com/N3PDF/pdfflow/blob/b5f608ceda1fb55adf3a3be63c4b321fe4e5dca6/benchmarks/compare_performance_lhapdf.py#L141-L146

Additional information

The thing is in order to give the uncertainties on this numbers in the plots I missed to dived by sqrt of the number of experiments.

We provided just 10 experiments, then the bars should be smaller by just a factor of three. They where almost invisible, so this wouldn't be a big issue in the plots.

I propose to include from now the correction factor. Let me know what you think, thanks.

scarrazza commented 4 years ago

Ok, please update the code so we can rerun the plot.