search

N3PDF / pycompressor

Compression code for PDF replicas.
https://n3pdf.github.io/pycompressor/
GNU General Public License v3.0
1 stars 0 forks source link

Start validphys App #20

Closed Radonirinaunimi closed 4 years ago

Radonirinaunimi commented 4 years ago

This is just a test to understand how things really work from the validphys side.

scarlehoff commented 4 years ago

It seems to work fine (still running). I would make the entry point of to be the validphys app (you might need to move the app inside the src/pycompressor folder) and you are practically done.

Radonirinaunimi commented 4 years ago

While writting the validphys app, I did not fully understand every bit of the lines of code. Small parts were not totally clear to me. So, as time passes by we will probably find a few parts that have to be modified.

By this,

It seems to work fine (still running). I would make the entry point of to be the validphys app (you might need to move the app inside the src/pycompressor folder) and you are practically done.

you mean getting rid of the run.py file?

scarlehoff commented 4 years ago

you mean getting rid of the run.py file?

in practice i guess so yes

Radonirinaunimi commented 4 years ago

@scarlehoff How does one install Validphys within a github action? Shouldn't it be just conda install -y validphys -c https://packages.nnpdf.science/conda?

scarrazza commented 4 years ago

You have to install the nnpdf package which is stored in a password protected repo https://packages.nnpdf.science/conda-private. Please following the installation guide here.

Radonirinaunimi commented 4 years ago

Right, it is actually in the conda-private (I've forgotten this). Thanks @scarrazza.

Radonirinaunimi commented 4 years ago

Now, I think the action is working now. There might be a better way to add the .condarc file, for instance having it as a file in the source directory. I just have to fix the coverage thing.

scarlehoff commented 4 years ago

Tbh, i'd rather have it only in the action. I think the way you are doing it is as good as it gets.

Radonirinaunimi commented 4 years ago

I think this PR has achieved its purpose? The Validphys app is working fine. Now I am preparing to purge the GANs within everything. So, I guess this can be closed?