search

N3developertoolkit / neo3-visual-tracker

Neo N3 blockchain explorer that is directly available within Visual Studio Code for developer usage and development scenarios.
https://marketplace.visualstudio.com/items?itemName=ngd-seattle.neo3-visual-tracker
MIT License
7 stars 11 forks source link

[UX] Provide feedback on contract with no storage #125

Open ixje opened 2 years ago

ixje commented 2 years ago

If one explores the contract storage of a contract that has no storage (e.g. StdLib) then nothing happens. I think it would be an improvement to let the user know there is no storage used by the contract. I happen to choose StdLib the first time I tried this view and thought it was broken until I thought about it and reliazed it has no storage.

image

robliou commented 2 years ago

Erik, please let me know if something like this is what you had in mind:

https://github.com/ngdenterprise/neo3-visual-tracker/pull/139

A9

A10

ixje commented 2 years ago

Hi Rob,

It is hard to tell from the screenshots but if i’m not mistaken you added the note to the contract information panel, not to the storage explorer that this issues is refering to.

I did a quick look at the PR and you seem to match on the contract name. I think a more dynamic approach that looks at the returned storage count being 0 is more future proof.

On 1 Jun 2022, at 17:05, Rob L. @.***> wrote:

 Erik, I believe I addressed this here, please have a look:

139

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.