N3rd00d / ComfyUI-Paint3D-Nodes

Apache License 2.0
47 stars 6 forks source link

"Holes" in the projected mask #11

Open Belze006 opened 2 months ago

Belze006 commented 2 months ago

Apparently, for meshes with higher simplex count, the projection map occurs to have blank spots. Why is that? Which parameters can we tweak to have seamless maps?

Apart from that: ComfyUI 3D Pack (https://github.com/MrForExample/ComfyUI-3D-Pack) has a great suite top create meshes by creating turnaround images and/or normal maps. Has anyone a good workflow that leverages these features in paint3d?

Belze006 commented 1 month ago

GPT says: The GenerateInpaintMask node in Paint3D is responsible for detecting unpainted areas in the viewport and creating mask images for inpainting. These masks are used by the inpainting model to apply textures to unpainted sections of the model as seen from different camera angles. Based on the functionality of this node, a potential cause of visible seams could be related to how the masks are generated and applied.

If the dilation process (applied to the depth map) is too aggressive or not properly handled, it may cause the edges of the masks to overlap inconsistently, leading to the seams you’re noticing. Another possible issue could be with the alignment of projected images when rotating the model, which might result in slight mismatches between different views.

What to check or adjust:

  1. Mask Generation: Ensure that the masks created by GenerateInpaintMask are not overly dilated or misaligned. Reducing the dilation could prevent excessive mask overlap.

  2. Projection Accuracy: Check how accurately the texture projection aligns with the unpainted regions, especially when rotating the camera. Misalignments between different inpainting steps could be a contributing factor.

  3. Depth Map Dilation: Consider reducing or modifying the dilation applied to the depth map, as it might expand regions too far, affecting the texture coverage.

By tweaking these parameters, you may reduce the appearance of black lines and seams in your output.

Belze006 commented 1 month ago

image

sekkit commented 1 month ago

so how the progress on solving the issue?