search

N4S4 / synology-api

A Python wrapper around Synology API
MIT License
368 stars 138 forks source link

Typed #111

Closed pnearing closed 1 year ago

pnearing commented 1 year ago

I typed all the functions in the classes.

N4S4 commented 1 year ago

This was a huge job and thank you very much for it. What do you think if you PR me this in a new branch? For two reason First I don't have much time I would feel shame to not continue this best practice Second I don't want to spoil this great job

Making the new branch I can see if I can keep It up and eventually merge it

Is it ok for you?

pnearing commented 1 year ago

Hey, yeah that's not a problem, I'd just like to contribute in anyway since I use this lib. I'm honestly not too familiar with git / github yet. So what ever you think would be best.

Peter N

N4S4 commented 1 year ago

you know diving into typing now I regret not merging this straight into master branch

pnearing commented 1 year ago

Thank you very much, I'm glad I could help. I was thinking about working on exceptions for the api, such as requests.raise_for_status. What do you think?

N4S4 commented 1 year ago

I think it would be good!