search

N4S4 / synology-api

A Python wrapper around Synology API
MIT License
399 stars 145 forks source link

Logging with custom base_url instead of ip/port and use SSL/HTTPS #20

Closed tduboys closed 3 years ago

tduboys commented 4 years ago

On the auth.py, you creates the base_url using the params ip_address/port. It should be great if we can directly give a base_url for some reasons :

I will try to submit a PR that can manage both ways, to not break something.

tduboys commented 4 years ago

Hi, I looked on the Improving-code branch. I liked the simplicity of the master branch, but now, It looks too complicated for me. I tried to understand the good way to work with this new code, and I didnt succed to login on my NAS…

As I see, this branch is a work-in-progress. I will wait for a merge on master to try again.

N4S4 commented 4 years ago

yes is still in progress and most things won't work, probably also the login function, we didn't work much on it as we don't have much time due to our jobs, anyway ithe plan of improving-code branch is to have a better way to use all modules (filestation, downloadstation etc.) with one SID without logging in again reducing the process workload of the sinology and of the user, also to simplify the processi of modifying functions thanks to the decorator in synology.py module. It will probably take time before implementing to master improving-code to master, so i will be keeping upgrading the main one (master) until improving-code is completed and tested, it will still remain but I will support it less and less as it uses more system resources than the master. I dunno if the above explanation is clear let me know please!

fletchgraham commented 4 years ago

would this allow for using the webapi with quickconnect?

N4S4 commented 4 years ago

@fletchgraham quickconnect is not working with the api, as reverse proxy is not supported yet

let's keep this section tidy for the issues only, please if you have any other question I have just made a group where we can talk on Telegram you can find it at https://t.me/SynologyApi or on Slack at https://bit.ly/SynologyApi both are newly made so no one except me is in them for now. I prefer using Telegram, I am "always" available on there

N4S4 commented 4 years ago

Https option has been added from @Egor-S pr #22 with little modification.