search

N4S4 / synology-api

A Python wrapper around Synology API
MIT License
368 stars 138 forks source link

Add https endpoint support #22

Closed Egor-S closed 4 years ago

Egor-S commented 4 years ago

Build _base_url with https or http (default) schema

tduboys commented 4 years ago

Instead of adding another parameter, is it not better to pass directly the base url ? And use a second constructor that builds this URL from IP/PORT combo for compatibility reasons. cf #20

N4S4 commented 4 years ago

help me to understand the #20 was not implemented in this one? which one is the most recent? I think i made a bit of a mess reverting the repository and i think i cancel your PR I did it as was not clear in my mind which one is the most recent as I find conflicts on this PR. I tested #23 and was good. let me know so i can test and merge the final one.

thank you for your help!

Egor-S commented 4 years ago

I think you should close my PR, because it adds only one case for base_url (https support, no reverse-proxy).

N4S4 commented 4 years ago

ok i just close this #23 was close automatically after the merge. I'll wait for ur final PR