N4S4 / synology-api

A Python wrapper around Synology API
MIT License
391 stars 143 forks source link

Base url #23

Closed tduboys closed 4 years ago

tduboys commented 4 years ago

About #20 Another way to initiate objects. On some setups, the Synology DSM is available on custom urls (if there is a reverse proxy for example)

It's useful for HTTPS (like #22 )

I tested on a remote NAS with LetsEncrypt certificate, and with FileStation and DownloadStation (I dont have other stuffs enabled on my Syno)

With this way, it's mandatory to set the param names when creating the authentication object, for the compatibility way with the method described on the Readme.

tduboys commented 4 years ago

I will try to do the same for the improve-code branch.

N4S4 commented 4 years ago

it is a good idea to implement base_url as authentication option I did not think about.

thank you!