search

N5GEH / n5geh.tools.entirety

GNU General Public License v3.0
9 stars 6 forks source link

142 update semantics app #145

Closed JRadebold closed 7 months ago

djs0109 commented 7 months ago

@JRadebold @SBlechmann I see that this feature is still not there in this branch https://github.com/N5GEH/n5geh.tools.entirety/pull/105#issuecomment-1695238735 . Is the plan that to implement it in another branch/issue?

djs0109 commented 7 months ago

@JRadebold Generally it looks good to me, I have only have some small comments above. Besides, I found slightly different behavior in different browsers (Firefox and Chrome). Could you check it out too?

JRadebold commented 7 months ago

@JRadebold @SBlechmann I see that this feature is still not there in this branch #105 (comment) . Is the plan that to implement it in another branch/issue?

JRadebold commented 7 months ago

@JRadebold Generally it looks good to me, I have only have some small comments above. Besides, I found slightly different behavior in different browsers (Firefox and Chrome). Could you check it out too?

I checkt it out too, but couldnt find any major differences. What differences were there in your case?

JRadebold commented 7 months ago

@JRadebold @SBlechmann I see that this feature is still not there in this branch #105 (comment) . Is the plan that to implement it in another branch/issue?

Maybe we have misunderstood each other? Now I have solved the problem by adding the dropdown menu with possible matches as soon as you start typing in the search field. I found highliting all entities in real time in the grapf rather confusing, especily with IDs, since usually they all start with "urn:ngsi-ld" and then all entites are higlighted.