search

N8python / n8ao

An efficient and visually pleasing implementation of SSAO with an emphasis on temporal stability and artist control.
Creative Commons Zero v1.0 Universal
378 stars 14 forks source link

Multiple instances of Three js being imported #1

Closed vis-prime closed 1 year ago

vis-prime commented 1 year ago

heyyyy !!! 👋

so I'm testing the pass and I got this warning WARNING: Multiple instances of Three.js being imported.

so checked the node modules folder and there's another node modules inside your npm package n8

and the package.json has 

 "dependencies": {
        "three": "^0.152.2"
    },

I guess three should be peerDependency instead of regular dependency like in https://github.com/pmndrs/postprocessing/blob/3e6ea9d8fddd2ca2d269e2182752f8199b8248af/package.json#L88-L89

Awesome work as always !!

N8python commented 1 year ago

very weird! I'll make it a peer dependency. New to all the NPM stuff.

N8python commented 1 year ago

Fixed with latest release.