NAD-ITS / alps-gutenberg-blocks

A Wordpress plugin to create Gutenberg plugins that work for ALPS.
0 stars 0 forks source link

ALPS Gutenberg Blocks Content Review #1

Open designerbrent opened 1 year ago

designerbrent commented 1 year ago

After reviewing the new blocks, there are a couple of changes that need to be addressed before they get merged:

Content Read More

Pattern: https://alps.adventist.io/v3/?p=molecules-content-read-more

Screen Shot 2022-10-30 at 10 24 32 AM

This block is currently hiding ALL the content (see screenshot above) until you click the button.

Todo:

Content Step Block

https://alps.adventist.io/v3/?p=molecules-step-blocks ✅ This block looks good.

Split Content Block

Pattern: https://alps.adventist.io/v3/?p=molecules-split-highlight-content ✅ This block looks good.

Highlight Blocks

Pattern: https://alps.adventist.io/v3/?p=organisms-highlight-blocks ✅ This block looks good.

betsyandrew commented 1 year ago

@designerbrent Updated PR here: https://github.com/adventistchurch/alps-gutenberg-blocks/pull/90

designerbrent commented 1 year ago

@betsyandrew I looked at the PR you mentioned and you didn't make any changes to the "Content Read More" block, just the "Content Show More".

The problem mentioned above is still an issue.