fix: check channel_types when syncing - Githubissues

NAFTeam / NAFF

A Python API wrapper for Discord

https://naff.info

MIT License

117 stars 24 forks source link

fix: check channel_types when syncing #739

Closed AstreaTSS closed 1 year ago

AstreaTSS commented 1 year ago

What type of pull request is this?

[x] Non-breaking code change
[ ] Breaking code change
[ ] Documentation change/addition
[ ] Tests change
[ ] CI change
[ ] Other: [Replace with a description]

Description

Can you tell I'm trying to finish Astro's rewrite?

Anyways, yeah, channel_types wasn't being checked for syncing, so this fixes that.

Changes

Add an entry for channel_types for the options_lookup in _compare_options.

Test Scenario(s)

Make a slash command with a channel option type and with a specified channel_type.
Sync it, change the channel type, then sync again.
Commands are still the same, the logger shows that no commands were overriden.

Checklist

[x] I've formatted my code with Black
[x] I've added docstrings to everything I've touched
[x] I've ensured my code works on Python 3.10.x
[x] I've ensured my code works on Python 3.11.x
[x] I've tested my changes
[x] I've added tests for my code - if applicable
[x] I've updated the documentation - if applicable