NAL-i5K / GFF3toolkit

Python programs for processing GFF3 files
Other
95 stars 27 forks source link

gff3_fix error #118

Closed elor77 closed 2 years ago

elor77 commented 3 years ago

I ran gff3_QC with no problems. When I run gff3_fix i get the following error:

INFO     Checking QC report file (error.txt)...
INFO     Checking GFF3 file (DUL_02_latest_Melon_V4_liftoff.gff)...
INFO     Reading QC report file: (error.txt)...

INFO     Reading GFF3 file: (DUL_02_latest_Melon_V4_liftoff.gff)...

Traceback (most recent call last):
  File "/home/eoren/miniconda3/bin/gff3_fix", line 8, in <module>
    sys.exit(script_main())
  File "/home/eoren/miniconda3/lib/python3.9/site-packages/gff3tool/bin/gff3_fix.py", line 95, in script_main
    gff3_fix.fix.main(gff3=gff3, output_gff=args.output_gff, error_dict=error_dict, line_num_dict=line_num_dict, logger=logger_null)
  File "/home/eoren/miniconda3/lib/python3.9/site-packages/gff3tool/lib/gff3_fix/fix.py", line 683, in main
    fix_phase(gff3=gff3, error_list=error_dict[error_code], line_num_dict=line_num_dict, logger=logger)
  File "/home/eoren/miniconda3/lib/python3.9/site-packages/gff3tool/lib/gff3_fix/fix.py", line 437, in fix_phase
    phase = (3 - ((CDS['end'] - CDS['start'] + 1 - phase) % 3)) % 3
TypeError: unsupported operand type(s) for -: 'int' and 'str'
ZhiXuanLai commented 3 years ago

Hi @elor77, I wonder if you could provide the gff3 file and the report from gff3_QC. That would be very helpful for debugging!

elor77 commented 3 years ago

Hi @ZhiXuanLai
Sure, here you go. This is a gff file created with https://github.com/agshumate/Liftoff

DUL_pseudomol_v1.0_Melon_V4_liftoff.gff.gz error.txt.gz

mpoelchau commented 3 years ago

@elor77 thanks for posting this issue. We are still trying to figure out the problem. In the meantime, I'd recommend following the solution posted here: https://github.com/agshumate/Liftoff/issues/67#issuecomment-804528269

mpoelchau commented 2 years ago

@elor77 apologies that I didn't follow up on this. The latest version of the gff3toolkit should handle this problem. https://github.com/NAL-i5K/GFF3toolkit/releases/tag/v2.1.0

elor77 commented 2 years ago

Thank you!