NAL-i5K / tripal_chado_datasets

Provides an admin layer and forms for users to submit organisms and analysis into Chado
0 stars 0 forks source link

tripal_chado_datasets_md_delete_form defined but never used? #16

Closed bradfordcondon closed 5 years ago

bradfordcondon commented 5 years ago

tripal_chado_datasets_md_delete_form previously md_delete_form is defined but never used. Doublecheck against base code.

bradfordcondon commented 5 years ago

heres what it looks like: separate edit and delete forms were previously defined for each analysis subtype. Below is from the "backup" module file, but its not in the datasets.module file.

  $items['admin/structure/datasets/report'] = array(
    'title' => 'Datasets Report',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('dataset_report'),
    'access arguments' => array('administer datasets'),
    'type' => MENU_LOCAL_TASK,
    'file' => 'datasets.admin.inc',
  );

  $items['datasets_og/%/view'] = array(
    'title' => 'View assembly information',
    'page callback' => 'assembly_information_view',
    'page arguments' => array(1),
    'access arguments' => array('administer datasets'),
    'type' => MENU_CALLBACK,
    'file' => 'datasets.admin.inc',
  );  

  $items['datasets_og/%/delete'] = array(
    'title' => 'Delete gene assembly information',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('datasets_og_delete_form', 1),
    'access arguments' => array('administer datasets'),
    'type' => MENU_CALLBACK,
    'file' => 'datasets.admin.inc',
  );

  $items['datasets_gp/%/view'] = array(
    'title' => 'View Gene prediction Information',
    'page callback' => 'gene_prediction_view',
    'page arguments' => array(1),
    'access arguments' => array('administer datasets'),
    'type' => MENU_CALLBACK,
    'file' => 'datasets.admin.inc',
  );

  $items['datasets_gp/%/delete'] = array(
    'title' => 'Delete gene prediction information',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('datasets_gp_delete_form', 1),
    'access arguments' => array('administer datasets'),
    'type' => MENU_CALLBACK,
    'file' => 'datasets.admin.inc',

Now there is a single delete and view:


  $items['datasets_og/%/delete'] = [
    'title' => 'Delete dataset information',
    'page callback' => 'drupal_get_form',
    'page arguments' => ['datasets_og_delete_form', 1],
    'access arguments' => ['administer datasets'],
    'type' => MENU_CALLBACK,
    'file' => 'includes/tripal_chado_datasets.admin.inc',
  ];
  $items['datasets/%/view'] = [
    'title' => 'View dataset information',
    'page callback' => 'datasets_information_view',
    'page arguments' => [1],
    'access arguments' => ['administer datasets'],
    'type' => MENU_CALLBACK,
    'file' => 'includes/tripal_chado_datasets.admin.inc',
  ];