Remove i5k specific info from email templates

NAL-i5K / tripal_chado_datasets

Provides an admin layer and forms for users to submit organisms and analysis into Chado

0 stars 0 forks source link

Remove i5k specific info from email templates #34

Closed bradfordcondon closed 5 years ago

bradfordcondon commented 5 years ago

we accomplish this largely by replacing i5k site name and url with the drupal site_name variable, and the global base_url variable.
The original templates are in https://github.com/NAL-i5K/i5k_custom_tripal although we may not need them any more.
Before this can be merged, i'd like to generate the test emails locally.

bradfordcondon commented 5 years ago

because i dont want to spend too much time debugging how to get my dev site sending emails (I know drupal by default is using php's mail function but I doubt I have it set up) I used the outgoing mail log module to log the messages that get sent.

https://www.drupal.org/project/mail_logger

here are teh two resulting messages from submitting an organism request:

screen shot 2018-10-02 at 1 39 02 pm

screen shot 2018-10-02 at 1 40 59 pm

a) whats up with the rendering? Does that render properly? I need to look into that. b) The newline spacing is inconsistent in the body text. c) "requested for new project" d) space missing in user-facing message

mpoelchau commented 5 years ago

Looks like you got the 2 emails as intended. We don't care a lot about the rendering/text to the admin (the first email), but it could certainly be improved... We cared more about the text that the end user would receive.

bradfordcondon commented 5 years ago

I'm trying to figure out if its supposed to render into something nicer... would you be willing to share an admin email you've received for an request @mpoelchau via slack or email?

that said point taken and i agree, the text to the end user is far more important so ill take extra care with that.

in the above you can see it uses my site name (Site-Install) so from here on out i htink its just improvements to this.

bradfordcondon commented 5 years ago

very helpful, thank you! In that case this issue is taken care of and I'l make a seperate one for further improvements to the email template styling...