dataset submission view is not great

NAL-i5K / tripal_chado_datasets

Provides an admin layer and forms for users to submit organisms and analysis into Chado

0 stars 0 forks source link

dataset submission view is not great #42

Closed bradfordcondon closed 5 years ago

bradfordcondon commented 5 years ago

Editing a dataset (chado analysis) to confirm doesn't look styled properly to me:

from /admin/structure/datasets/report, edit a submission.

Heres what http://localhost:8083/datasets/1/view looks like for me:

screen shot 2018-10-03 at 12 20 51 pm

Is this comparable to what's live, or is there something wrong with the styling? In this case its using the "Assembly" template, which does seem to only make use of <p> and <b> elements.

Seems to me like using standard drupal table theming would be a big improvement from this.

mpoelchau commented 5 years ago

Yep, that's the way it is right now. Happy to have any improvements.

bradfordcondon commented 5 years ago

I switched to just looping through key/value pairs and setting in a table, with a "legend" lookup array to change the machine label for a human readable one.

More legible? It's certainly more code-friendly since the display is no longer hard-coded. I unset fields that have no value (for example sex and strain above), do we need to display those blank values @mpoelchau ?

It occurs to me that these fields should be editable by the admin to correct typos etc. I think that will be a "next release" feature since I'm liking the "workbench style" approach more and more...

bradfordcondon commented 5 years ago

merging without the approve/delete buttons, which will belong to #1