search

NAL-i5K / tripal_eutils

ncbi loader via the eutils interface
GNU General Public License v3.0
4 stars 3 forks source link

too many property widgets! #106

Open bradfordcondon opened 5 years ago

bradfordcondon commented 5 years ago

solutions:

Put widget in a fieldset.

use feature_cvterm instead

almasaeed2010 commented 5 years ago

can't use _cvterm because we need a term and a value

Maybe Tripal shouldn't auto create fields for props like it currently does and allows developers/admins to choose which fields to create. If that was true, we could design our own field to handle the props differently. Should we take this to core?

bradfordcondon commented 5 years ago

i'd definitely like to raise the issue in core, citing that this module will create up to 500 biosample properties because thats what NCBI defines.

two distinct problems, too- cluttering hte input form, and cluttering the admin area

almasaeed2010 commented 5 years ago

make that 3 since the queries will be executed in all biosample pages although not all will have values for the 500 fields (unless I am misunderstanding something). If this is true, it'd make our biosample pages very slow.

bradfordcondon commented 5 years ago

they wont have field instances attached unless theyre populated so i dont believe it would fire a query.