search

NAL-i5K / tripal_eutils

ncbi loader via the eutils interface
GNU General Public License v3.0
4 stars 3 forks source link

log status to the job console #206

Closed bradfordcondon closed 5 years ago

bradfordcondon commented 5 years ago

screen shot 2019-02-28 at 11 23 27 am

honestly I feel like this is a core issue, using the correct tripal log method should log it here too.

Anyway, for now lets just fix it and make sure the messages get logged there too.

bradfordcondon commented 5 years ago

got it!

the Importer lcass has a $job attribute available, so we just pass that in to EUtils and then pass the job into the tripal_report_error call.

@mpoelchau i think you'll be pleased to see this

screen shot 2019-02-28 at 11 48 22 am

bradfordcondon commented 5 years ago

Merged! However:

I think a big improvement would be to pass the job into the repositories as well- that way, those classes can also log to the job HUD-- this is largely desirable for printing out if a record was already found in the db and wont be re-inserted, as right now that happens "silently"

Additionally i wnat ot make sure that the master catch is also logging

edit: done!

screen shot 2019-02-28 at 12 20 26 pm