NAL-i5K / tripal_eutils

ncbi loader via the eutils interface
GNU General Public License v3.0
4 stars 3 forks source link

NCBI Data loader warning #214

Closed Tenncp closed 4 years ago

Tenncp commented 4 years ago

Using the NCBI data loader with "aassembly" selected and accession number 91111 produces the following warning:

Warning: count(): Parameter must be an array or an object that implements Countable in EUtilsAssemblyParser->getFTPData() (line 206 of /home/cphill/drupal7/sites/all/modules/tripal_eutils/includes/xml_parsers/EUtilsAssemblyParser.inc).

Ferrisx4 commented 4 years ago

@Tenncp Was this using the "Preview Record" or "Import NCBI Record" button, and other than the Warning that you mentioned, was the loader able to pull anything from NCBI at all?

Tenncp commented 4 years ago

It was using the "Import NCBI Record" button. The loader appeared to load the data from NCBI just fine.


From: Sean Buehler notifications@github.com Sent: Wednesday, September 18, 2019 10:09 AM To: NAL-i5K/tripal_eutils tripal_eutils@noreply.github.com Cc: Phillips, Charles Alexander cphill25@vols.utk.edu; Mention mention@noreply.github.com Subject: Re: [NAL-i5K/tripal_eutils] NCBI Data loader warning (#214)

@Tenncphttps://github.com/Tenncp Was this using the "Preview Record" or "Import NCBI Record" button, and other than the Warning that you mentioned, was the loader able to pull anything from NCBI at all?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/NAL-i5K/tripal_eutils/issues/214?email_source=notifications&email_token=ANEXT4U55VG76QUFMZVADATQKIZB3A5CNFSM4IVIV2QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7AGFNI#issuecomment-532701877, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANEXT4X2MTAWY4C5XAVGRH3QKIZB3ANCNFSM4IVIV2QA.

Tenncp commented 4 years ago

The error is due to a misplaced parenthesis. The warning is eliminated by changing line 206 from if (count($values == 0)) { to if (count($values) == 0) {

__

Ferrisx4 commented 4 years ago

Fixed by #222, closing