NAL-i5K / tripal_eutils

ncbi loader via the eutils interface
GNU General Public License v3.0
4 stars 3 forks source link

Namespace and functionality conflict with Tripal Analysis Expression #233

Closed Ferrisx4 closed 1 year ago

Ferrisx4 commented 2 years ago

The module uses a generic namespace when loading the NCBI Sample Terms and this conflicts with the same functionality provided by the Tripal Expression Analysis module. In this module, both the namespace and idspace are ncbi_properties whereas in Tripal Analysis Expression module, these are NCBI Sample Attributes and NCBI_Sample_Terms, respectively.

See the initial discussion here in https://github.com/tripal/tripal_analysis_expression/pull/392#issuecomment-1073030325

The suggested solution by @spficklin and @dsenalik this:


Discussion also mentioned the possibility of having this module take on this functionality alone and for the Tripal Expression Analysis module to depend on this module being installed instead, but the above alternative was favored.

dsenalik commented 1 year ago

Third item resolved with merged pull request #247

dsenalik commented 1 year ago

Testing on an empty tripal 3 site revealed a few install | uninstall issues. Submitting a pull request to fix these.

250 and #251