search

NAMeC-team / CRAbE

GNU General Public License v3.0
4 stars 3 forks source link

[ft-rbc23] More gk area points, shape refactor in structs #93

Closed Wanchai290 closed 8 months ago

Wanchai290 commented 10 months ago

Instead of having points in the struct, the structures Penalty and Goal use instead the struct Rectangle to define these points. Additionally, the original attributes have been kept so that the viewer (aquarium) can still display properly what it receives.

This PR requires some additional changes on aquarium, which have been addressed by a new branch on its repository (crabe-refac-shapes).

there are some weird twists in the code, notably because of notation issues. looks messy but I tried my best, looking for advice on how to improve this

Wanchai290 commented 10 months ago

With cd96011 it is not necessary to change anything to how we receive data in aquarium.

Wanchai290 commented 9 months ago

every issue mentioned has been resolved waiting for an update on this

EtienneSchmitz commented 9 months ago

I will look on this in the next few days