search

NARKOZ / gitlab

Ruby wrapper and CLI for the GitLab REST API
https://narkoz.github.io/gitlab
BSD 2-Clause "Simplified" License
1.06k stars 394 forks source link

Add users disable 2FA #646

Closed antons- closed 1 year ago

antons- commented 2 years ago

Adds support for the disable two factor authentication endpoint introduced in GitLab 15.2.

antons- commented 2 years ago

Regarding the failed Rubocop test - I wasn't sure on the best way to deal with this. Did we want to increase the line length limit?

asedge commented 2 years ago

You could disable the cop, via comment, for that one line. Not sure how @NARKOZ would feel about updating the line length for the whole project.

antons- commented 2 years ago

Thanks @asedge for the suggestion. For now I have disabled the cop via comment, and now all the tests are passing.

I should point out that the max limit for the Layout/LineLength cop is 127 characters - whereas my change makes the line 128 characters (1 character over the limit).

@NARKOZ Let me know what you think.

asedge commented 1 year ago

Thank you for your contribution! 😄