search

NARKOZ / gitlab

Ruby wrapper and CLI for the GitLab REST API
https://narkoz.github.io/gitlab
BSD 2-Clause "Simplified" License
1.06k stars 394 forks source link

Gitlab 16 deprecating changing MR Approvals using the `/approvals` endpoint #667

Closed Flexicon closed 1 year ago

Flexicon commented 1 year ago

See deprecation here: https://docs.gitlab.com/ee/update/deprecations.html?removal_milestone=16.0#changing-merge-request-approvals-with-the-approvals-api-endpoint

To change the approvals required for a merge request, you should no longer use the /approvals API endpoint, which was deprecated in GitLab 14.0.

Instead, use the /approval_rules endpoint to create or update the approval rules for a merge request.

The edit_merge_request_approvals method of this library still uses the deprecated POST /approvals endpoint: https://github.com/NARKOZ/gitlab/blob/26b49e34fb623f72802809ff737729d096b8f849/lib/gitlab/client/merge_request_approvals.rb#L127

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Flexicon commented 1 year ago

@NARKOZ is this not something the library is interested in? Would you be willing to accept contributions perhaps?