Update base Validator.content_val to return a proper default value. Validation that doesn't include a custom content_val implementation relies on this default implementation during validation checks. By default, that includes EVR and Limit dictionary checks. The current implementation incorrectly returns a garbage value (None) for the default implementation.
Documentation of the default content_val method has been updated to elaborate on why it's making the current check and what a more thorough implementation looks like.
Tangentially related, error handling around schema validation was a bit lacking. This also includes minor updates around the schema_val checks in Validator to better handle and log exceptions related to that. Additionally, validation is short circuited if failures occur there to avoid confusing error messages in unrelated content_val checks.
Update base Validator.content_val to return a proper default value. Validation that doesn't include a custom
content_valimplementation relies on this default implementation during validation checks. By default, that includes EVR and Limit dictionary checks. The current implementation incorrectly returns a garbage value (None) for the default implementation.Documentation of the default
content_valmethod has been updated to elaborate on why it's making the current check and what a more thorough implementation looks like.Tangentially related, error handling around schema validation was a bit lacking. This also includes minor updates around the
schema_valchecks inValidatorto better handle and log exceptions related to that. Additionally, validation is short circuited if failures occur there to avoid confusing error messages in unrelatedcontent_valchecks.Resolve #507