NASA-AMMOS / AIT-Core

MIT License
45 stars 27 forks source link

Issue #538 - Formatting and Linting #539

Closed cjjacks closed 3 weeks ago

cjjacks commented 4 weeks ago

Run pre-commit run --all to apply formatting to all files and updated the max line length to 120 characters

nttoole commented 3 weeks ago
(venv) bash-3.2$ pre-commit run --all-files
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check for merge conflicts................................................Passed
Debug Statements (Python)................................................Passed
Reorder python imports...................................................Passed
mypy.....................................................................Passed
black....................................................................Passed
flake8...................................................................Passed
AIT TLM YAML check.......................................................Passed
AIT CMD YAML check.......................................................Passed
AIT EVR YAML check.......................................................Passed
AIT LIMITS YAML check....................................................Passed
(venv) bash-3.2$ pytest
...
============================================= 250 passed, 2 skipped, 11 warnings in 4.47s ==============================================

Successfully configured and ran AIT-GUI and ait_example:

image

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.8% Duplication on New Code

See analysis details on SonarCloud

nttoole commented 3 weeks ago

@cjjacks Just checking if this is ready for final review or if there are any expected changes? Thanks

cjjacks commented 3 weeks ago

@nttoole Sorry for the last minute update! Was just double checking and realized that I had committed updates to the lock file which didn't necessarily belong in this PR. Should be good to go now.