NASA-AMMOS / AIT-DSN

MIT License
19 stars 10 forks source link

common.SLE doesn't define necessary set of attributes #107

Open MJJoyce opened 4 years ago

MJJoyce commented 4 years ago

This isn't really a high priority issue, especially considering that common.SLE is really just a base class for the SLE interfaces. But still ...

        if not self._hostnames or not self._port:
            msg = 'Connection configuration missing hostnames ({}) or port ({})'
            msg = msg.format(self._hostnames, self._port)
            ait.core.log.error(msg)
            raise ValueError(msg)

SLE.__init__ has checks for hostname and port information but these attributes aren't defined default in SLE. They're instead defaulted in the inherited interface classes (RAF, RCF, etc.). Should clean that up unless there's a compelling reason to leave it in its current state.

kmarwah commented 4 years ago

I'm working on this!