search

NASA-AMMOS / AIT-DSN

MIT License
19 stars 10 forks source link

Convert string to byte string on common.py #118

Closed Futabay closed 4 years ago

Futabay commented 4 years ago

In Python3, there is no implicit conversion between string object and byte object. Thus, for example, string and byte-string concatenation is not working.

https://github.com/NASA-AMMOS/AIT-DSN/blob/4780d6d5c54a2b7b6ee71285bd08d15e2c937129/ait/dsn/sle/common.py#L446

Following stings need to be converted to byte-string

https://github.com/NASA-AMMOS/AIT-DSN/blob/4780d6d5c54a2b7b6ee71285bd08d15e2c937129/ait/dsn/sle/common.py#L435

https://github.com/NASA-AMMOS/AIT-DSN/blob/4780d6d5c54a2b7b6ee71285bd08d15e2c937129/ait/dsn/sle/common.py#L454

https://github.com/NASA-AMMOS/AIT-DSN/blob/4780d6d5c54a2b7b6ee71285bd08d15e2c937129/ait/dsn/sle/common.py#L465

MJJoyce commented 4 years ago

Resolved in #120