During initial testing of the ait_sle_interface_manager, a couple of issues were discovered that will need to be addressed:
1) RAF/RCF start request requires start and end arguments
There is a comment note indicating such, but the args are required else the service won't work.
Bottle supports parameters, tho the method should also handle case of no params and default to None
2) RCF start also needs spacecraft and channel arguments:
e.g. rcf_mngr.start(start, end, 250, 0, master_channel=True)
3) UDP Service handle() method is missing address argument
def handle(self, data, address) ...
Also some recommendations:
1) When calling a SLE-interface lifecycle method, we should be checking its resulting state (since the underlying interface will track errors and update its internal state accordingly).
2) CLTUServer should maintain a list of packets instead of single packet, and update its upload logic to push all packets until list is empty.
3) The service state set should probably be updated to use enums to better track state and transitions.
During initial testing of the ait_sle_interface_manager, a couple of issues were discovered that will need to be addressed:
1) RAF/RCF start request requires
startandendarguments There is a comment note indicating such, but the args are required else the service won't work. Bottle supports parameters, tho the method should also handle case of no params and default toNone2) RCF start also needs spacecraft and channel arguments: e.g.
rcf_mngr.start(start, end, 250, 0, master_channel=True)3) UDP Service handle() method is missing address argument
def handle(self, data, address) ...Also some recommendations:
1) When calling a SLE-interface lifecycle method, we should be checking its resulting state (since the underlying interface will track errors and update its internal state accordingly).
2) CLTUServer should maintain a list of packets instead of single packet, and update its upload logic to push all packets until list is empty.
3) The service state set should probably be updated to use enums to better track state and transitions.