NASA-AMMOS / AIT-DSN

MIT License
19 stars 10 forks source link

Issue #39 Update FCLTU for V4 and V5 #41

Closed lorsposto closed 6 years ago

lorsposto commented 6 years ago

Resolves #39

GetParameter is not implemented yet and so there is no GetParameter test.

MJJoyce commented 6 years ago

I'm looking at this again and I'm really not liking the idea of replacing classes like this. I suppose we could avoid this mess if we require that users configure what version of the interfaces they want to use so we can intelligently import stuff. That's not really friendly if we're allowing version negotiation with the harness but I think that's functionality that isn't really needed. Projects are going to have negotiated and set in stone interface details so there isn't going to be a need to negotiate down a version.

I realize it means more changes to this but what do you think about that @lorsposto? Have a config option for picking interface versions and it defaults to v5 if nothing is specified. At least then we can intelligently import modules without having to fiddle around with overwrites and whatnot.

lorsposto commented 6 years ago

@MJJoyce Agreed; updated the version logic to check ait.config before importing either v4 or v5.