search

NASA-AMMOS / AIT-DSN

MIT License
19 stars 10 forks source link

Fix issue #74 #75

Closed kmarwah closed 5 years ago

kmarwah commented 5 years ago

Resolves #74

aywaldron commented 5 years ago

Hey @kmarwah, thanks for the fix. I think we'd like to keep the generic grabbing of the class that was merged in previously, but just add the frame instantiation with input data. Could you edit this to keep using the getattr approach for getting the frame class and add another step that instantiates it like in the if/else statements, but using the frame class returned by getattr?

kmarwah commented 5 years ago

Hey @aywaldron, I just fixed the instantiation issue while keeping the generic grabbing of the class. Let me know what you think!

aywaldron commented 5 years ago

Hi @kmarwah, this looks great, thanks very much!