NASA-AMMOS / aerie-cli

An unofficial CLI for interacting with Aerie planning software
MIT License
3 stars 4 forks source link

Time offset format is inconsistent between plan JSON and Aerie UI #87

Open parkerabercrombie opened 9 months ago

parkerabercrombie commented 9 months ago

The Aerie UI (and GraphQL response) displays start offests as hh:mm:ss.sss. Aerie always shows number of hours, even if the offset is more than 24 hrs. However, when I download a plan using the aerie-cli the offset is represented as "D days, hh:mm:ss.sss". For example "start_offset": "2 days, 0:59:59.897000", where as in the Aerie GUI, it's 48:59:59.897.

This difference in format makes it difficult to match up times in the plan JSON file with activities in the Aeri/e UI. We should use the same offset format as in Aerie.

cartermak commented 9 months ago

I'd be happy to support an audit of time formats with some more intentional design decisions like this. I'll just note that this would be another breaking change to the plan JSON format; the current time/duration string formats are based on standard string-ify methods from Python libraries, so any other tools that interact with JSON plans would need to update their de/serialization to handle a custom format.

parkerabercrombie commented 7 months ago

I think it would be worth a breaking change to standardize with the Aerie time format. Let's talk about the potential impact to other tools.

cartermak commented 1 week ago

Adding some notes here in support of the Aerie Plan JSON format effort: