search

NASA-AMMOS / aerie-ui

The client application for Aerie.
https://nasa-ammos.github.io/aerie-docs/
MIT License
29 stars 5 forks source link

UI is using SimulationDatasetId instead of DatasetId #1121

Closed Mythicaeda closed 7 months ago

Mythicaeda commented 7 months ago

Checked for duplicates

No - I haven't checked

Is this a regression?

Yes - This worked in a previous version

Version

2.1.0

Describe the bug

This bug was likely introduced in #1017, L305 of +page.svelete

Instead of grabbing the actual dataset_id from the simulation dataset, it is treating the simulation_dataset_id as dataset_id. This causes problems when the dataset_id and simulation_dataset_id fall out of sync (for example, via adding external datasets). Once this desync happens, the UI will either fail to get any results for a sim run, or will fetch incorrect results.

Reproduction

  1. Create a plan
  2. Add an external dataset via the API
  3. Simulate the plan

Example video on a localhost venue where the desync was caused by running the external dataset E2E tests in Aerie core:

https://github.com/NASA-AMMOS/aerie-ui/assets/62574120/b2100b6d-c6c7-4792-a27d-9f9d9ca30f68

Database entry for this request. Notice how the dataset id does not equal the request's id:

image

Query that the UI made to get the spans. Notice that it used 107, the request id, instead of 133, the dataset id

image

Logs

No response

System Info

MacOs, Firefox

Severity

Major

parkerabercrombie commented 7 months ago

This is a blocking bug for Clipper.