Open dandelany opened 6 months ago
First pass at design / UI working group 02/21/24
Reviewed two directions. a) side panel design for editing metadata + associations and b) full page model editor.
Workflows:
General Feedback:
Feedback A:
Feedback B:
Open questions:
Next steps:
Screenshot A:
Screenshot B:
Panel design v2:
Full page design v2:
The full page approach to model spec editing is ready to go pending a few design tweaks: https://www.figma.com/file/CbNZdWaWBgjxaN6BnX6xva/Aerie-%231128---Model-Specifications-(Constraints%2C-Goals%2C-Conditions)?type=design&node-id=64-30615&mode=design&t=WecElOFTI6JWGkZ5-4
Remaining design items here:
Showing goals, constraints, and conditions in the plan needs a bit more design work, but is getting close.
@duranb ready to roll here!
Thanks @lklyne ! Will open a new ticket for implementation
Design direction for model spec editing
https://www.figma.com/file/CbNZdWaWBgjxaN6BnX6xva/Aerie-%231128---Model-Specifications-(Constraints%2C-Goals%2C-Conditions)?type=design&node-id=64-30615&mode=design&t=y8MHOqu1eXBTygZn-4
Design direction for panel updates in plan + surfacing errors
https://www.figma.com/file/CbNZdWaWBgjxaN6BnX6xva/Aerie-%231128---Model-Specifications-(Constraints%2C-Goals%2C-Conditions)?type=design&node-id=114%3A24078&mode=design&t=y8MHOqu1eXBTygZn-1
Background
For our "Shared Constraints and Goals" milestone, we are changing how constraints, goals and conditions work in Aerie. Previously, these could only exist if they were attached to a specific plan. In the new implementation, they exist in a shared "library" and don't have to be attached to a plan at the time of creation. They are also now versioned, whereas before there was only a single version that was replaced when edited.
There will now be two ways to attach constraints, goals, and conditions to a plan:
Requirements
New UI designs are needed for editing the three kinds of Model Specifications (model constraint spec, model goal spec, model conditions spec). I'll use constraints below for brevity, but unless otherwise specified, these apply to all three types:
Proposals
One way to do this is to add a new page to Aerie (tentatively called "Model Editor" or "Model Details"), accessed from the Models page by clicking on an individual model row (or an icon on the row). The page could contain a section at the top for editing the model's metadata (title, description, author), followed by sections for Model Constraint Spec, Goal Spec and Condition Spec. The UIs for the Spec sections could be basically the same UIs from the plan editor panels (ie. a list with a "Manage constraints" button which opens a modal to select from the library)
Another option is to try & fit all of this into a new right panel on the Models page which would appear when you clicked a model, but this may be too much information to squeeze into a panel.
Notes:
Plan Spec Screenshots
For reference, here is the new workflow for modifying the plan spec, implemented in #1118, which should be reused where possible:
In the Constraints panel in the plan editor, the user can click "Manage Constraints" to add/remove constraints from the library, which pops up a modal:
When they add constraints and click "Update", the panel is updated with the new list of constraints on the plan: