search

NASA-AMMOS / aerie-ui

The client application for Aerie.
https://nasa-ammos.github.io/aerie-docs/
MIT License
28 stars 5 forks source link

Fixes the seq editor repeat arg issue and a typescript not registered… #1142

Closed cohansen closed 5 months ago

cohansen commented 5 months ago

… error we were seeing

Closes #1130.

This fixes the problem we were seeing with repeat args, turns out we don't need the code that was doing an extraneous check because it was originally added for doing arithmetic inside the sequence editor.

This also fixes another issue I was seeing where getting the tsworker was failing because the editor wasn't ready.

duranb commented 5 months ago

@cohansen Sorry...actually, I just saw that the MonacoEditor component dispatches a fullyLoaded event with the TS worker in the payload. I tested it locally, by just using the worker from the event to update the model config, instead of using an editor event listener, and it seems to be working in the same manner? It still doesn't validate the model on load until something is typed, but I don't know if that's a separate issue.

duranb commented 5 months ago

I found something that works to validate on load, but I'm hoping that there's potentially another way that you might know of that's a little bit less heavy handed. https://stackoverflow.com/questions/56050816/is-there-a-way-to-trigger-validation-manually-in-monaco-editor