search

NASA-AMMOS / aerie-ui

The client application for Aerie.
https://nasa-ammos.github.io/aerie-docs/
MIT License
28 stars 4 forks source link

Fix editing of plan tags #1166

Closed AaronPlave closed 3 months ago

AaronPlave commented 3 months ago

Restore plan update permissions check, closes #1165.

Testing:

  1. Create a plan as User A with role = aerie_admin
  2. Open Plan Metadata panel and verify that you are able to add and remove tags from Tags input
  3. Switch to role = user and re-verify step 2
  4. Switch to role = viewer and verify that you are not allowed to edit the tags input
  5. Logout and login as a different user and load the plan created in step 1
  6. Verify that you are only able to edit the tags input on User A's plan while role = aerie_admin.
AaronPlave commented 3 months ago

LGTM, tested locally with the scenarios mentioned + a few more. Thanks @AaronPlave !

Since @duranb is OOO today & this is a high priority fix, I'd advocate for merging this ASAP to make sure it gets included in our 2.6.0 release. I'll add a reference to @duranb 's comment in the UI refactor ticket so we can tackle it with the other refactoring stuff.

Heads up that I can't merge since changes are requested