search

NASA-AMMOS / aerie-ui

The client application for Aerie.
https://nasa-ammos.github.io/aerie-docs/
MIT License
28 stars 4 forks source link

Split `Test` workflow into `Unit` and `E2E` Jobs #1227

Closed Mythicaeda closed 2 months ago

Mythicaeda commented 2 months ago

This should help speed up testing, as Unit tests no longer have to await E2E test setup/execution, and if one set of tests fails, only that set needs to be rerun. This also means unit tests will be checked even if E2E tests fail.

Note for @dandelany and @joswig that this changes how the test artifacts are uploaded by splitting them into two artifacts named Unit Test Results and E2E Test Results.

AaronPlave commented 2 months ago

Seems like the test workflow is hanging

Mythicaeda commented 2 months ago

Seems like the test workflow is hanging

I think what's going on is the test job is set as required for develop and not the test workflow, since the workflow itself isn't hanging. If I rename one of the jobs in the workflow to test, the checks no longer hang and only that job of the two is tagged as "required".

image
duranb commented 2 months ago

Seems like the test workflow is hanging

I think what's going on is the test job is set as required for develop and not the test workflow, since the workflow itself isn't hanging. If I rename one of the jobs in the workflow to test, the checks no longer hang and only that job of the two is tagged as "required".

image

Ohh so we need to just specify the two tests explicitly in the github settings?

Mythicaeda commented 2 months ago

Seems like the test workflow is hanging

I think what's going on is the test job is set as required for develop and not the test workflow, since the workflow itself isn't hanging. If I rename one of the jobs in the workflow to test, the checks no longer hang and only that job of the two is tagged as "required".

image

Ohh so we need to just specify the two tests explicitly in the github settings?

Yup! Or if there's a way to specify "all jobs in this workflow" instead, that would work.

duranb commented 2 months ago

Seems like the test workflow is hanging

I think what's going on is the test job is set as required for develop and not the test workflow, since the workflow itself isn't hanging. If I rename one of the jobs in the workflow to test, the checks no longer hang and only that job of the two is tagged as "required".

image

Ohh so we need to just specify the two tests explicitly in the github settings?

Yup! Or if there's a way to specify "all jobs in this workflow" instead, that would work.

Nice! I'll try it out after the release.