Add simulation events table panel

NASA-AMMOS / aerie-ui

The client application for Aerie.

https://nasa-ammos.github.io/aerie-docs/

MIT License

28 stars 4 forks source link

Add simulation events table panel #1236

Closed mattdailis closed 2 months ago

mattdailis commented 2 months ago

This PR adds a table for visualizing simulation events.

Some use cases that motivate this:

Emitting warnings from simulation. Sometimes an exception is too much, and a resource doesn't quite feel like the right tool
Logging information from the mission model to provide additional information about actions performed by an activity

This information is already captured in the database, but there isn't yet a way to visualize it.

Future work:

Associating events with the span in which they were emitted
Potentially visualizing these events on the timeline
Richer filtering, and perhaps providing some "log level" like customization and color coding
Related to that last point @duranb pointed out that logs might live naturally in the bottom console

dandelany commented 2 months ago

In our demos today, we got some user feedback from @parkerabercrombie that it would make more sense for these events to appear in the same place as the error console (accessible from the bottom bar) rather than a separate table in a panel. @mattdailis let me know if you'd like to include that change in this PR or if I should open a separate ticket.

AaronPlave commented 2 months ago

In our demos today, we got some user feedback from @parkerabercrombie that it would make more sense for these events to appear in the same place as the error console (accessible from the bottom bar) rather than a separate table in a panel. @mattdailis let me know if you'd like to include that change in this PR or if I should open a separate ticket.

My guess is that this would require a small bit of discussion and design work to determine how this should live within the error console. I'd lean towards a followup PR but defer to whatever @mattdailis thinks.

duranb commented 2 months ago

In our demos today, we got some user feedback from @parkerabercrombie that it would make more sense for these events to appear in the same place as the error console (accessible from the bottom bar) rather than a separate table in a panel. @mattdailis let me know if you'd like to include that change in this PR or if I should open a separate ticket.

My guess is that this would require a small bit of discussion and design work to determine how this should live within the error console. I'd lean towards a followup PR but defer to whatever @mattdailis thinks.

I second a followup PR. It might be good to get this out in front of more users as is so that they can give other feedback that we can also include in the followup.